Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notations of loopback addresses #7474

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Conversation

wataash
Copy link
Contributor

@wataash wataash commented Aug 4, 2019

127.0.0.1/8 refers to only a single IPv4 address "127.0.0.1" that have the subnet mask 255.255.255.0, but doesn't to 127.0.0.2.
127.0.0.0/8, which is the exact definition of the loopback addresses [1][2], includes what the regex says (127.0.0.0-127.255.255.255).

@wataash wataash changed the title Fix notation of loopback addresses Fix notations of loopback addresses Aug 4, 2019
127.0.0.1/8 refers to only a single IPv4 address "127.0.0.1" that have
the subnet mask 255.255.255.0, but doesn't to 127.0.0.2.
127.0.0.0/8, which is the exact definition of the loopback addresses
[1][2], includes what the regex says (127.0.0.0-127.255.255.255).

[1] https://tools.ietf.org/html/rfc1122
[2] https://tools.ietf.org/html/rfc6890
@iansu
Copy link
Contributor

iansu commented Oct 23, 2019

Thanks!

@iansu iansu merged commit 5ea3b34 into facebook:master Oct 23, 2019
@lock lock bot locked and limited conversation to collaborators Oct 28, 2019
@wataash wataash deleted the loopback-address branch December 6, 2019 02:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants